Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add services field into package manifest.yml #125

Closed
wants to merge 4 commits into from
Closed

Add services field into package manifest.yml #125

wants to merge 4 commits into from

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Feb 3, 2021 •
edited
Loading

What does this PR do?

This PR is to add a new services field option into the package manifest.yml file. For example:

services:
  - name: aws_ec2
    title: AWS EC2
    release: beta
    description: AWS EC2 Integration
    icons:
      - src: /img/logo_aws_ec2.svg
        title: logo aws ec2
        size: 32x32
        type: image/svg+xml
    data_streams:
      - ec2_logs
      - ec2_metrics

Why is it important?

With this new field, we can expose services under a package to users as separate integrations in Fleet Integrations list. For example, instead of only showing users we support AWS integration, we can also show AWS EC2, AWS SNS and etc.

Checklist

Related issues

@kaiyan-sheng kaiyan-sheng requested review from ycombinator, justinkambic and mtojek and removed request for justinkambic February 3, 2021 02:52
@elasticmachine
Copy link

elasticmachine commented Feb 3, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

    • Start Time: 2021-02-04T22:46:36.373+0000

  • Duration: 1 min 18 sec

  • Commit: 0abec59

@kaiyan-sheng kaiyan-sheng self-assigned this Feb 3, 2021
@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Feb 3, 2021
ruflin
ruflin requested changes Feb 3, 2021
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please hold off on PR's until we agree on the right format to use in #122 ?

@ycombinator
Copy link
Contributor

@ruflin Sure, but I thought there was agreement in #122. Can you point to something in #122 where there is disagreement? Maybe I missed something...

@mtojek mtojek marked this pull request as draft February 4, 2021 09:29
@kaiyan-sheng
Copy link
Contributor Author

Closing this draft after we discussed more on the design.

@kaiyan-sheng kaiyan-sheng deleted the add_services branch February 19, 2021 19:18
rw-access pushed a commit to rw-access/package-spec that referenced this pull request Mar 23, 2021
@mtojek
Update base docker image for EPR (elastic#125)
998d7e8 
* WIP

* Use docker command to fetch base image for EPR

* Fix: sort fields

* Remove TODO file

* Fix: comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin requested changes

@ycombinator ycombinator Awaiting requested review from ycombinator

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiyan-sheng @elasticmachine @ycombinator @ruflin